[Flight] Allow cyclic references to be serialized when unwrapping lazy elements #35471
+70
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails with: ``` TypeError: Converting circular structure to JSON --> starting at object with constructor 'Object' --- property 'self' closes the circle ```
github-actions
bot
added
the
React Core Team
|
Comparing: d6cae44...ee803e6 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
unstubbable
added a commit
to vercel/next.js
that referenced
this pull request
Jan 8, 2026
Requires a fix in React to pass (possibly facebook/react#35471). closes #86401
gnoff
approved these changes
Jan 16, 2026
Collaborator
gnoff
left a comment
gnoff
left a comment
There was a problem hiding this comment.
This forks the handling of lazy object rendering depending on whether it is outlined or inlined. But I think this is right. If you inline the lazy then you want to preserve the chain of object deduplication through this boundary and thus need the parent property and key. If you are outlining the lazy then you can't preserve the chain and you just rend from a new root. I don't know why it was inlined with an empty root in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
renderModelDestructiveunwraps a lazy element and subsequently callsrenderModelDestructiveagain with the resolved model, we should preserve the parent connection so that cyclic references can be serialized properly. This can occur in an advanced scenario where the result from the Flight Client is serialized again with the Flight Server, e.g. for slicing a precomputed payload into multiple parts.Note: The added test only fails when run with
--prod. In dev mode, the component info outlining prevents the issue from occurring.